Skip to content

feat: add modal update#87

Merged
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:modalupdate
May 28, 2025
Merged

feat: add modal update#87
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:modalupdate

Conversation

@mhduiy

@mhduiy mhduiy commented May 28, 2025

Copy link
Copy Markdown
Contributor
  • Users can choose whether to perform modal updates
  • Update the logo of deepin

pms: TASK-377199

- Users can choose whether to perform modal updates
- Update the logo of deepin

pms: TASK-377199
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • UpdateWorker类中,doDistUpgradeIfCanBackup函数中,doDistUpgrade函数的调用应该检查canBackupneedBackup的值,而不是直接调用。
  • UpdateWorker类中的onBackupStatusChanged函数应该处理更多的状态变化,而不仅仅是failedend
  • UpdateWidget类中的onJobProgressChanged函数应该根据hasBackup的值来计算进度,而不是直接使用传入的value
  • UpdateProgressWidget类中的setValue函数应该根据hasBackup的值来计算进度,而不是直接使用传入的value

是否建议立即修改:

@deepin-ci-robot

Copy link
Copy Markdown

@mhduiy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
deepin-auto-translation cb840b1 link true /test deepin-auto-translation

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, xionglinlin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 7289481 into linuxdeepin:master May 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants